I agree with everything you have said - well done on the quality of the notes! But I do beg to differ.. I don't believe in persuasive techniques..
May I ask what your English SS was?
I tend to use 'persuasive technique' as an umbrella term encompassing everything from specific words and phrases to you 'textbook' examples like rhetorical questions and emotional appeals. What I'm trying to say when you should identify these techniques is to look for the key words and phrases that reveal the writer's contention or line of argument. Terms like 'rhetorical question', 'appeal to hip pocket nerve' etc. are really just terminology. Listing these doesn't get you any more marks than if you were to identify all the nouns and adjectives.
I think it is legitimate to criticise the phrase 'persuasive technique'. Its a term I don't really like as well but I use it because it has a common understood meaning amongst students. I don't think that you should specifically go out of your way to avoid using any of those terms - if you are analysing the way the writer uses rhetorical questions then there is nothing wrong with saying it is a rhetorical question, so long as you realise it is your analysis of the writer's language and not identifying the 'technique' that is getting you the marks.